Conversation
gatesn
added
changelog/feature
github-actions
bot
removed
the
action/benchmark-sql
Comment on lines
+12
to
+16
| struct ReusableDict { | ||
| buffer_ptr<VectorChildBuffer> buffer; | ||
|
|
||
| explicit ReusableDict(buffer_ptr<VectorChildBuffer> buf) : buffer(std::move(buf)) { | ||
| } |
Contributor
There was a problem hiding this comment.
Cann we not use a ExternalVectorBuffer here?
Comment on lines
+30
to
+32
| // FIXME(ngates): SetDictionaryId has been removed in favor of ReusableDictionary | ||
| // auto ddict = reinterpret_cast<duckdb::Vector*>(dict); | ||
| // DictionaryVector::SetDictionaryId(*ddict, std::string(id, id_len)); |
Contributor
There was a problem hiding this comment.
How do you know we don't need this? I think we need to see no perf regression?
Contributor
Author
There was a problem hiding this comment.
Agreed. I'm also checking with DuckDB Labs
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
duckdb/v1.5-variegata
branch
from
7c4e318 to
1b5ab73
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Contributor
|
Pushed a few fixes
|
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark-sql
Merging this PR will not alter performance
Comparing 
Footnotes
|
a10y
force-pushed
the
duckdb/v1.5-variegata
branch
from
2ad8e4b to
845e9c9
Compare
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
duckdb/v1.5-variegata
branch
from
845e9c9 to
f935e52
Compare
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Deploying vortex-bench with
|
| Latest commit: |
8d83eb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://125f533f.vortex-93b.pages.dev |
| Branch Preview URL: | https://duckdb-v1-5-variegata.vortex-93b.pages.dev |
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
github-actions
bot
removed
the
action/benchmark-sql
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the breaking changes from DuckDB 1.4 to 1.5.
The DuckDB extension repo https://github.com/vortex-data/duckdb-vortex/ has an equivalent
v1.5-variegatabranch that builds against this branch until 1.5 is released. At that point, we should merge this branch to develop.Before merging, we should update the build.rs to reference the released build:
https://github.com/vortex-data/vortex/pull/5901/changes#diff-9ed191f629d48027cda20fcf842b19e37d8340b098bb5ef96303a682a2d32fc2L26-R27
Fixes #5889